Eagerly enter launch and async blocks with unconfined dispatcher.
#3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix `Dispatchers.Main` not delegating `Delay` methods and discover that, on JS, `Dispatchers.Main` gets reset during the test if it is reset in `AfterTest`.
qwwdfsad
reviewed
Nov 8, 2021
| * | ||
| * ``` | ||
| * @Test | ||
| * fun testEagerlyEnteringChildCoroutines() = runTest(UnconfinedTestDispatcher()) { |
There was a problem hiding this comment.
By the way, what do you think about providing runTestUnconfined for a better migration path?
There was a problem hiding this comment.
I don't like it because of this confusing behavior:
val ctx = StandardTestDispatcher()
@Test
fun test() = runTestUnconfined(ctx) {
// not unconfined
}
|
I added separate |
dkhalanskyjb
force-pushed
the
coroutines-test-eagerly-enter
branch
from
43cecf5 to
61461a3
Compare
qwwdfsad
approved these changes
Nov 9, 2021
|
|
dkhalanskyjb
added a commit
that referenced
this pull request
Nov 17, 2021
Also, fix `Dispatchers.Main` not delegating `Delay` methods and discover that, on JS, `Dispatchers.Main` gets reset during the test if it is reset in `AfterTest`.
dkhalanskyjb
added a commit
that referenced
this pull request
Nov 17, 2021
Also, fix `Dispatchers.Main` not delegating `Delay` methods and discover that, on JS, `Dispatchers.Main` gets reset during the test if it is reset in `AfterTest`.
dkhalanskyjb
added a commit
that referenced
this pull request
Nov 19, 2021
Also, fix `Dispatchers.Main` not delegating `Delay` methods and discover that, on JS, `Dispatchers.Main` gets reset during the test if it is reset in `AfterTest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@qwwdfsad found a convenient migration path for most tests that rely on
launchandasyncblocks being entered eagerly. Implemented it here.Also, I fixed
Dispatchers.Mainnot delegatingDelaymethods and discovered that, on JS,Dispatchers.Maingets reset during the test if it is reset inAfterTest.