Skip to content

fix: build fails if JDK_16 is not set #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: build fails if JDK_16 is not set #294

wants to merge 1 commit into from

Conversation

venkatperi
Copy link
Contributor

No description provided.

@venkatperi venkatperi mentioned this pull request Mar 20, 2018
Closed
@jcornaz
Copy link
Contributor

jcornaz commented Mar 20, 2018 •
edited
Loading

Wouldn't it be better to simply specify in the readme that it is necessary to specify a JDK_16 environment variable?

And/Or make the build fail with a more explicit message.

But I wouldn't make the build succeed by automatically skipping tests.

@elizarov
Copy link
Contributor

elizarov commented Mar 20, 2018 •
edited
Loading

We cannot just skip the requirement for JDK_16. It has to be built against JDK 1.6 runtime in order to be compatible with JDK 1.6. We should give a clear error message when JDK_16 is not set.

@venkatperi
Copy link
Contributor Author

Closing. Missing JDK_16 should throw an error.

@venkatperi venkatperi closed this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@venkatperi @jcornaz @elizarov