Remove obsolete CommonPool support #2916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
qwwdfsad
commented
Sep 3, 2021
qwwdfsad
commented
* We state that it's deprecated since the initial release of CoroutineScheduler
* It is an additional DEX load for Android
dkhalanskyjb
approved these changes
Sep 9, 2021
| @@ -25,7 +25,7 @@ internal actual object DefaultExecutor : CoroutineDispatcher(), Delay { | |||
|
|
|||
| internal fun loopWasShutDown(): Nothing = error("Cannot execute task because event loop was shut down") | |||
|
|
|||
| internal actual fun createDefaultDispatcher(): CoroutineDispatcher = | |||
| internal fun createDefaultDispatcher(): CoroutineDispatcher = | |||
There was a problem hiding this comment.
Can't this be inlined, like on the JVM?
There was a problem hiding this comment.
It will complicate the maintenance of native-mt branch during rebases
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
* We state that it's deprecated since the initial release of CoroutineScheduler * It is an additional DEX load for Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.