Skip to content

Fix BlockHound false positive in stack trace recovery #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

Fix BlockHound false positive in stack trace recovery #2895

merged 1 commit into from
Sep 2, 2021

Conversation

qwwdfsad
Copy link
Member

Fixes #2894

@qwwdfsad qwwdfsad requested a review from dkhalanskyjb August 25, 2021 09:07
@qwwdfsad
Copy link
Member Author

I feel like it doesn't worth adding a stress test for that. Tested manually by adding Thread.sleep to line 47 in ExceptionConstructor

dkhalanskyjb
dkhalanskyjb approved these changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qwwdfsad qwwdfsad merged commit 6055432 into develop Sep 2, 2021
@qwwdfsad qwwdfsad deleted the bh-fp branch September 2, 2021 09:14
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Fix BlockHound false positive in stack trace recovery (Kotlin#2895)
202b5bb 
Fixes Kotlin#2894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @dkhalanskyjb