Skip to content

Fix js tests #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Fix js tests #2824

merged 4 commits into from
Jul 16, 2021

Conversation

qwwdfsad
Copy link
Collaborator

No description provided.

qwwdfsad added 2 commits July 14, 2021 18:43
    * Wrap them in 'withContext(Job)' instead of 'runTest' to be properly working on JS
    * Skip few way too slow for JS tests only on JS platform

Fixes #2820
@qwwdfsad qwwdfsad requested a review from dkhalanskyjb July 15, 2021 16:08
@qwwdfsad qwwdfsad requested a review from dkhalanskyjb July 16, 2021 09:57
@qwwdfsad qwwdfsad merged commit 2571516 into develop Jul 16, 2021
@qwwdfsad qwwdfsad deleted the fix-js-tests branch July 16, 2021 11:39
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
* Properly detect asynchronous tests that try to use `runTest` multiple times

* Refactor multi-shot tests

    * Wrap them in 'withContext(Job)' instead of 'runTest' to be properly working on JS
    * Skip few way too slow for JS tests only on JS platform

Fixes Kotlin#2820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants