Properly detect non-released reusable continuations in non-reusable o… #2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't look like I can add comments to lines that aren't part of the change, so writing it here:
|
* Ensure that the caller to DispatchedContinuation.isReusable is reusable itself
* Using previous invariant, simplify DispatchedContinuation.isReusable to a single null-check
* It also restores the invariant that `cc.isReusable() == cc.resumeMode.isReusableMode`
|
While answering your comments, I've found a more simple, robust and approachable way to do the same thing. |
dkhalanskyjb
approved these changes
Jun 23, 2021
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Kotlin#2772) * Properly detect non-released reusable continuations in non-reusable ones and await for reusability to have a consistent state * Ensure that the caller to DispatchedContinuation.isReusable is reusable itself * Using the previous invariant, simplify DispatchedContinuation.isReusable to a single null-check * It also restores the invariant that `cc.isReusable() == cc.resumeMode.isReusableMode` Fixes Kotlin#2736 Fixes Kotlin#2768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nes and await for reusability to have a consistent state
Fixes #2736
Fixes #2768