Skip to content

Replace InternalCoroutinesApi with deprecation in NonCancellable #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2021
Merged

Replace InternalCoroutinesApi with deprecation in NonCancellable #2765

merged 1 commit into from
Jun 16, 2021

Conversation

qwwdfsad
Copy link
Member 

* ICA is misused here as lint, for which we consistently use @Deprecated in other places
* The current state is incompatible with 1.5.30 where KT-45844 is implemented

@qwwdfsad
Replace InternalCoroutinesApi with deprecation in NonCancellable
d9ed11f 
    * ICA is misused here as lint, for which we consistently use @deprecated in other places
    * The current state is incompatible with 1.5.30 where KT-45844 is implemented
@qwwdfsad qwwdfsad requested a review from dkhalanskyjb June 15, 2021 12:46
@qwwdfsad
Copy link
Member Author

Will be promoted to ERROR in the next major release

@qwwdfsad qwwdfsad merged commit 38535bf into develop Jun 16, 2021
@qwwdfsad qwwdfsad deleted the deprecate-non-cancellable-methods branch June 16, 2021 09:13
LepilkinaElena pushed a commit that referenced this pull request Jun 21, 2021
@qwwdfsad
Replace InternalCoroutinesApi with deprecation in NonCancellable (#2765)
66b8119 
* ICA is misused here as lint, for which we consistently use @deprecated in other places
* The current state is incompatible with 1.5.30 where KT-45844 is implemented
woainikk pushed a commit that referenced this pull request Jun 22, 2021
@qwwdfsad @woainikk
Replace InternalCoroutinesApi with deprecation in NonCancellable (#2765)
88c45a9 
* ICA is misused here as lint, for which we consistently use @deprecated in other places
* The current state is incompatible with 1.5.30 where KT-45844 is implemented
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Replace InternalCoroutinesApi with deprecation in NonCancellable (Kot…
2333070 
…lin#2765)

* ICA is misused here as lint, for which we consistently use @deprecated in other places
* The current state is incompatible with 1.5.30 where KT-45844 is implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @dkhalanskyjb