update: update coroutines-guide.md #2661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the links to the additional references
qwwdfsad
requested changes
Apr 20, 2021
docs/topics/coroutines-guide.md
Outdated
| @@ -31,6 +31,6 @@ In order to use coroutines as well as follow the examples in this guide, you nee | |||
|
|
|||
| ## Additional references | |||
|
|
|||
| * [Guide to UI programming with coroutines](https://github.com/Kotlin/kotlinx.coroutines/blob/master/ui/coroutines-guide-ui.md) | |||
| * [Coroutines design document (KEEP)](https://github.com/Kotlin/kotlin-coroutines/blob/master/kotlin-coroutines-informal.md) | |||
| * [Guide to UI programming with coroutines](https://github.com/Kotlin/kotlinx.coroutines/blob/develop/ui/coroutines-guide-ui.md) | |||
There was a problem hiding this comment.
But it has to be pointing to the current master which is the state of the last stable release, not to develop.
Maybe the problem is in something elese?
There was a problem hiding this comment.
Suggested change
| * [Guide to UI programming with coroutines](https://github.com/Kotlin/kotlinx.coroutines/blob/develop/ui/coroutines-guide-ui.md) | |
| * [Guide to UI programming with coroutines](https://github.com/Kotlin/kotlinx.coroutines/blob/master/ui/coroutines-guide-ui.md) |
There was a problem hiding this comment.
Oh, it's my bad.
I was on the develop branch when preparing the PR and copied the wrong link.
qwwdfsad
approved these changes
Apr 20, 2021
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the links to the additional references
https://youtrack.jetbrains.com/issue/KT-45090
KT-45090 Broken link for "Guide to UI programming with coroutines"