Public experimental shutdown method on DefaultDispatcher #2652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Apr 15, 2021
mvicsokolova
force-pushed
the
defalut-dispatcher-shutdown
branch
from
0358568 to
4420c79
Compare
qwwdfsad
requested changes
Apr 19, 2021
| * - On Kotlin/Native requests termination of the worker created by the [Default] dispatcher. | ||
| */ | ||
| @ExperimentalCoroutinesApi | ||
| public fun CoroutineDispatcher.shutdown() |
There was a problem hiding this comment.
The signature seems to be not really usable because it has two receivers and also has effect only on the default dispatcher in K/N which is a bit weird.
I'd suggest sticking with Dispatchers.shutdownDefaultDispatcher while we don't have a separate type for Dispatchers.Default and cannot do Dispatchers.Default.shutdown().
sab-regime
approved these changes
Apr 23, 2021
sab-regime
approved these changes
Apr 23, 2021
qwwdfsad
force-pushed
the
native-mt
branch
3 times, most recently
from
f739cdb to
28fb12c
Compare
qwwdfsad
force-pushed
the
native-mt
branch
2 times, most recently
from
d4ad99a to
46f7abd
Compare
* Provides newSingleThreadedContext. * Provides Dispatchers.Main on iOS, Dispatchers.Default everywhere. * Coroutine references (Job), all kinds of channels and StateFlow are shareable across workers. * Each individual coroutine is confined to a single worker. * Update Dispatchers docs to account for native-mt changes. * Multithreaded support in select expression. * Fix ObjC autorelease object leaks with native-mt dispatchers (#2477) Additional fixes: * Fixed broadcast builder with different thread * Fixed adding a child to a frozen parent job Fixes #462 Fixes #470 Fixes #765 Fixes #1645 Fixes #1751 Fixes #1828 Fixes #1831 Fixes #1764 Fixes #2064 Fixes #2025 Fixes #2226 Fixes #2138 Fixes #2263 Fixes #2322 Fixes #2283 Fixes #2688
mvicsokolova
force-pushed
the
defalut-dispatcher-shutdown
branch
from
fd982ae to
ce4a323
Compare
qwwdfsad
requested changes
May 24, 2021
Co-authored-by: Vsevolod Tolstopyatov <[email protected]>
Co-authored-by: Vsevolod Tolstopyatov <[email protected]>
…in/kotlinx.coroutines into defalut-dispatcher-shutdown
qwwdfsad
force-pushed
the
native-mt
branch
3 times, most recently
from
8df9c27 to
48cf2cf
Compare
qwwdfsad
force-pushed
the
native-mt
branch
3 times, most recently
from
e0f92a6 to
386640c
Compare
|
Closing as won't fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2491