Skip to content

Embrace new channel API #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Embrace new channel API #2643

merged 3 commits into from
Apr 13, 2021

Conversation

qwwdfsad
Copy link
Collaborator

* Introduce trySendBlocking and deprecate sendBlocking
* Use it in callbackFlow example
* Stabilize callbackFlow and channelFlow as they finally have error-safe API
* Irrelevant: migrate from deprecated stdlib API to be able to build with Kotlin 1.5

@qwwdfsad qwwdfsad requested a review from elizarov April 12, 2021 11:21
@qwwdfsad qwwdfsad marked this pull request as draft April 12, 2021 11:35
    * Introduce trySendBlocking and deprecate sendBlocking
    * Use it in callbackFlow example
    * Stabilize callbackFlow and channelFlow as they finally have error-safe API
    * Irrelevant: migrate from deprecated stdlib API to be able to build with Kotlin 1.5
@qwwdfsad qwwdfsad marked this pull request as ready for review April 12, 2021 12:24
@qwwdfsad qwwdfsad force-pushed the stabilize-callback-flow branch from 183d5ab to e3f2b9f Compare April 12, 2021 12:24
@qwwdfsad qwwdfsad requested a review from elizarov April 12, 2021 13:20
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance!

@qwwdfsad qwwdfsad merged commit d905e82 into develop Apr 13, 2021
@qwwdfsad qwwdfsad deleted the stabilize-callback-flow branch April 13, 2021 10:05
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
* Embrace new channel API

    * Introduce trySendBlocking and deprecate sendBlocking
    * Use it in callbackFlow example
    * Stabilize callbackFlow and channelFlow as they finally have error-safe API
    * Irrelevant: migrate from deprecated stdlib API to be able to build with Kotlin 1.5


Co-authored-by: Roman Elizarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants