-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Mark GlobalScope as delicate API and rewrite coroutine basics doc without it #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hout it Also, remove the tutorial variant of the basic coroutine introduction as it essentially duplicates the content of the basic coroutine introduction, albeit with "how to create a project" additional information, which does not seem to be appropriate in this section at all. Fixes #2122
Please update api dump |
Excited to see this! Thank you. Curious what the fate is for some of the reactive stream interop APIs such as |
They don't really break out of structured concurrency, they encapsulated into the well-known world of cancellation in Rx. Supposedly, if you use them you are aware of the Rx-style approach to handling it. The story is different with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome guide re-write, well done!
Few minor comments and it's good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please don't forget to add opt-in to our Gradle scripts, because now all the rx integrations is highlighted with warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor improvements.
I hope that soon we will be able to bring all the documentation to our guidelines.
Co-authored-by: Vsevolod Tolstopyatov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Co-authored-by: Andrey Polyakov <[email protected]>
Fixed review commend, also:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
@elizarov may be |
IMO, |
This is awesome, thank you so much! |
…hout it (Kotlin#2637) Also, remove the tutorial variant of the basic coroutine introduction as it essentially duplicates the content of the basic coroutine introduction, albeit with "how to create a project" additional information, which does not seem to be appropriate in this section at all. Fixes Kotlin#2122 Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Co-authored-by: Andrey Polyakov <[email protected]>
Also, remove the tutorial variant of the basic coroutine introduction as it essentially duplicates the content of the
basic coroutine introduction, albeit with "how to create a project" additional information, which does not seem to be appropriate in this section at all.
Fixes #2122