Fix a flaky test in MonoTest #2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
fix-mono-test-breaking
branch
7 times, most recently
from
6c6229a to
7c74d4d
Compare
dkhalanskyjb
force-pushed
the
fix-mono-test-breaking
branch
from
7c74d4d to
0be54f7
Compare
qwwdfsad
approved these changes
Apr 8, 2021
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change's gist is that
monois being run in the unconfined dispatcher and not in the default one. There were all sorts of nasty races due tomonobeing passed to the default workers, while here, everything seems deterministic.