Add the missing type boundaries to the reactive integrations #2630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Judging by ReactiveX/RxJava#4644, the requirement 2.13 from the reactive spec (https://github.com/reactive-streams/reactive-streams-jvm#2.13) does mean that null values can't be passed to `onNext`. Thus, it is incorrect for `publish {...}` to accept nullable values.
`flux` and `mono` now have <T : Any>. `flux`, because it's illegal to emit `null` values, and `mono`, because it can be confusing for the user to be able to write `mono<String?>` to create a `Mono` that emits either `String` or no value at all.
This does not affect the range of representable programs, but, without the type boundary, the users could be confused into thinking that they could emit `null` as a value.
qwwdfsad
reviewed
Apr 8, 2021
There was a problem hiding this comment.
Sorry, we've discussed it before and decided not to do that (the end of DM by 2020-09-23).
It's a source-incompatible change to stable API that will require all authors of generic code to introduce Any constraint.
And any code that actually tries to emit null will fail at the first run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.