Skip to content

Remove deprecated SendChannel.isFull #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Remove deprecated SendChannel.isFull #2613

merged 2 commits into from
Apr 6, 2021

Conversation

qwwdfsad
Copy link
Collaborator

Also, give it default stub implementation and remove it from all the subclasses. This implementation previously was partially correct, was used as a performance optimization and can be safely introduced for a marginally popular method

Also, give it default stub implementation and remove it from all the subclasses. This implementation previously was partially correct, was used as a performance optimization and can be safely introduced for a marginally popular method
@qwwdfsad qwwdfsad requested a review from elizarov March 26, 2021 18:03
@qwwdfsad qwwdfsad requested a review from elizarov March 26, 2021 18:59
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

@qwwdfsad qwwdfsad changed the title Promote Channel.isFull deprecation to HIDDEN Remove deprecated SendChannel.isFull Apr 6, 2021
@qwwdfsad qwwdfsad merged commit eb963e8 into develop Apr 6, 2021
@qwwdfsad qwwdfsad deleted the is-full-riddance branch April 6, 2021 16:19
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants