Fix a test that was flaky because of BlockHound #2572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kotlinx.coroutines.debug.internal.DebugProbesImpl.updateState` sometimes parks in order to acquire a lock, which leads BlockHound to detect an illegal blocking call. Now, blocking calls inside `DebugProbesImpl` are permitted. Though allowing `updateState` would suffice, the other users of the lock seem safe, too, and are allowed even when it doesn't make much sense to call them from coroutines.
qwwdfsad
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunningThreadStackMergeTest.testStackMergeWithContextwas failing:https://teamcity.jetbrains.com/buildConfiguration/KotlinTools_KotlinxTrain_Kotlin140_LibrariesBranchesFor150Release/3329282?buildTab=tests&status=failed&expandedTest=4424896350783031328
kotlinx.coroutines.debug.internal.DebugProbesImpl.updateStatesometimes parks in order to acquire a lock, which leads BlockHound
to detect an illegal blocking call. Now, blocking calls inside
DebugProbesImplare permitted. Though allowingupdateStatewould suffice, the other users of the lock seem safe, too, and are
allowed even when it doesn't make much sense to call them from
coroutines.