Cleanup continuation field in lazily-started coroutines after the start to reduce potential memory pressure #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I've found that lazy broadcast is broken, but decided not to touch it because we are planning to deprecate it pretty soon anyway |
When starting a coroutine lazily by using CoroutineStart.LAZY, it creates a Continuation that would launch the coroutine block, which is stored in the returned Job or Deferred to be invoked lazily. However, this reference is never cleared, even after the coroutine ends. This prevents the coroutine block and it's enclosing class instance from being garbage collected if the Job or Deferred is retained in another class, or while child coroutines are running (as they also hold a reference to the Job). Fixed by clearing the reference to the Continuation after invoking it.
…rt to reduce potential memory pressure Also, as long as onStart is our own private API, replace checkNotNull with !! operator to save few bytecodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, as long as onStart is our own private API, replace checkNotNull with !! operator to save few bytecodes