Fix await/asDeferred for MinimalState implementations #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Dec 22, 2020
qwwdfsad
approved these changes
Dec 25, 2020
| try { | ||
| @Suppress("UNCHECKED_CAST") | ||
| return get() as T | ||
| @Suppress("UNCHECKED_CAST", "BlockingMethodInNonBlockingContext") |
There was a problem hiding this comment.
| // mayInterruptIfRunning is not used | ||
| (this as? CompletableFuture<T>)?.cancel(false) | ||
| consumer.cont = null // shall clear reference to continuation to aid GC | ||
| if (cont.isActive) { |
There was a problem hiding this comment.
Not a big fan of optimizations that work 0.01% of the time (when future completes after isDone check but after whenComplete): hard to test and reason about.
I may be too opinionated here tho
There was a problem hiding this comment.
Yep. It is indeed not needed anymore, where we (again) have fast-path via future.isDone here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2456