Preserve a frame with source code location when sanitizing traces #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
better-synthetic-method-sanitization
branch
from
8a3753d to
86ea871
Compare
qwwdfsad
approved these changes
Dec 28, 2020
| @@ -63,6 +63,7 @@ class SanitizedProbesTest : DebugTestBase() { | |||
| "\t(Coroutine creation stacktrace)\n" + | |||
| "\tat kotlin.coroutines.intrinsics.IntrinsicsKt__IntrinsicsJvmKt.createCoroutineUnintercepted(IntrinsicsJvm.kt:116)\n" + | |||
| "\tat kotlinx.coroutines.intrinsics.CancellableKt.startCoroutineCancellable(Cancellable.kt:23)\n" + | |||
| "\tat kotlinx.coroutines.BuildersKt__Builders_commonKt.async\$default(Builders.common.kt)\n" + | |||
There was a problem hiding this comment.
It seems like the actual frame (one with line numbers) points to the wrong line.
Typically, it's worth reporting it to our bugtracker (subsystem: Backend. JVM. Coroutines, assignee -- Ilmir)
| result += element | ||
| includeInternalFrame = true | ||
| result += stackTrace[i] | ||
| i += 1 |
There was a problem hiding this comment.
[nitpicking] ++i is a single BCI, so it's better to use it.
dkhalanskyjb
force-pushed
the
better-synthetic-method-sanitization
branch
from
86ea871 to
b4a5286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1437