Skip to content

Conditionally create an instance of CancellationException in Channel.… #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,7 @@ internal abstract class AbstractChannel<E>(
cancelInternal(cause)

final override fun cancel(cause: CancellationException?) {
if (isClosedForReceive) return // Do not create an exception if channel is already cancelled
cancelInternal(cause ?: CancellationException("$classSimpleName was cancelled"))
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ internal open class ChannelCoroutine<E>(
}

final override fun cancel(cause: CancellationException?) {
if (isClosedForReceive) return // Do not create an exception if channel is already cancelled
cancelInternal(cause ?: defaultCancellationException())
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ internal fun <T1, T2, R> zipImpl(flow: Flow<T1>, flow2: Flow<T2>, transform: sus
} catch (e: AbortFlowException) {
e.checkOwnership(owner = this@unsafeFlow)
} finally {
if (!second.isClosedForReceive) second.cancel()
second.cancel()
}
}
}