Skip to content

Remove platform-specific dependencies on JavaFx artifacts #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Remove platform-specific dependencies on JavaFx artifacts #2369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d16a66
Remove platform-specific dependencies on JavaFx artifacts
elizarov Nov 5, 2020
d188147
~ fixed test deps
elizarov Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ui/kotlinx-coroutines-javafx/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,20 @@
*/

plugins {
id("org.openjfx.javafxplugin")
id("org.openjfx.javafxplugin") version "0.0.9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be done by changing javafx_plugin_version in gradle.properties instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it seems that changing the version does nothing to fix the issue: the problem is solved by just making the edit to configuration below.

I'm making this comment just for documentation purposes.

}

javafx {
version = version("javafx")
modules = listOf("javafx.controls")
configuration = "compile"
configuration = "compileOnly"
}

sourceSets {
test.configure {
compileClasspath += configurations.compileOnly
runtimeClasspath += configurations.compileOnly
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through options provided by the JavaFX plugin, I don't see a better way to do this. Looking at discussions where other projects face the same problem (openjfx/javafx-gradle-plugin#85, https://stackoverflow.com/questions/60249348/run-gradle-tests-using-image-from-badass-runtime-plugin and some others), it seems that the community didn't yet find a clean solution either.

}

val JDK_18: String? by lazy {
Expand Down