Skip to content

Fix BlockHound false positives #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 26, 2020
Merged

Conversation

dkhalanskyjb
Copy link
Collaborator

No description provided.

@dkhalanskyjb dkhalanskyjb requested a review from qwwdfsad October 23, 2020 12:51
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revisit a few more places on our code that rely on fast locking:

  • StateFlow and SharedFlow
  • JobSupport (finalizeFinishingState & co.)

@dkhalanskyjb dkhalanskyjb force-pushed the blockHound-fix-false-positives branch from a0527e1 to c18c9b1 Compare October 23, 2020 16:40
@dkhalanskyjb
Copy link
Collaborator Author

Yeah, I completely missed that some code is protected using synchronized.

@dkhalanskyjb dkhalanskyjb requested a review from qwwdfsad October 23, 2020 16:44
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good, great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants