Add the model checking mode in Lincheck tests #2326
Conversation
ndkoval
force-pushed
the
lincheck-with-model-checking
branch
from
df9bb17 to
fc1bcb3
Compare
|
Here is a nightly build on Linux: https://teamcity.jetbrains.com/buildConfiguration/KotlinTools_KotlinxCoroutines_NightlyStress/3180685?buildTab=tests |
ndkoval
force-pushed
the
lincheck-with-model-checking
branch
from
fc1bcb3 to
c074deb
Compare
| @@ -10,7 +10,7 @@ package kotlinx.coroutines.internal | |||
| * @suppress **This is unstable API and it is subject to change.** | |||
| */ | |||
| internal class Symbol(val symbol: String) { | |||
| override fun toString(): String = symbol | |||
| override fun toString(): String = "<$symbol>" | |||
There was a problem hiding this comment.
This is just more readable, to distinguish symbols from strings/enums
…ter version of it
ndkoval
force-pushed
the
lincheck-with-model-checking
branch
from
83abfbe to
9209ec8
Compare
.idea/dictionaries/ndkoval.xml
Outdated
| @@ -0,0 +1,7 @@ | |||
| <component name="ProjectDictionaryState"> | |||
| <dictionary name="ndkoval"> | |||
There was a problem hiding this comment.
Please, give it some neutral name (like shared).
There was a problem hiding this comment.
In IDEA each user has its own dictionary to reduce merge conflicts with the global dictionary, but all these per-user dictionaries are used by IDEA independently on the current user.
There was a problem hiding this comment.
That's exactly my point. The dictionary that is committed to the report should not be your personal dictionary that is tied to your user-name, it shall be a common dictionary that is shared across the project.
There was a problem hiding this comment.
That is not how IntelliJ IDEA works (yes, the behavior is counterintuitive). You cannot create a dictionary with a custom name -- it will be automatically cleaned up by IntelliJ IDEA. Instead, there are per-user dictionaries which can be updated by each user personally -- when you use IntelliJ IDEA all these per-user dictionaries are used, so that your IDEA will know about the words listed in ndkoval dictionary. The original motivation (provided by the IntelliJ IDEA team) is that in this case you will not have merge conflicts on the dictionary since it is split by users. I, personally, would not agree with this solution (at least, I spent an hour trying to understand the behavior), but that is how it works.
There was a problem hiding this comment.
In conclusion,
- you cannot create dictionaries with custom names, and, in particular, a single global dictionary
- all per-user dictionaries are used in IDEA, independently of the current user
There was a problem hiding this comment.
Of course, you can. I've committed a fix.
.idea/dictionaries/ndkoval.xml
Outdated
| @@ -0,0 +1,7 @@ | |||
| <component name="ProjectDictionaryState"> | |||
| <dictionary name="ndkoval"> | |||
There was a problem hiding this comment.
Of course, you can. I've committed a fix.
No description provided.