-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix potential crashes in asFlow extensions for RxJava 2&3 integrations #2319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking this. May I request that the fix also be applied to Rx2 as well please? 🙂 |
Don't you want to do it now that you've seen my example, @mhernand40? |
@LouisCAD Typically I've seen bug fixes for Coroutines <-> Reactive APIs applied all throughout where applicable in the same PR. Hence why I am asking it be addressed within this PR. But I am also okay with tackling it in a separate PR provided this one gets approved first. Anyhow, FWIW I personally would be grateful if it would be addressed in this PR. 🙂 |
Done. |
…ss-tests Add rx2/rx3 stress tests for ObservableSource.asFlow()
I'm really hoping this makes it into the final Coroutines |
I've opened #2333 where I squashed all the changes into a single commit and added stable and small reproducer. Thanks for taking care of this issue! |
Fixes #2299
Related to issue #974