Skip to content

Pr/2230 #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 8, 2020
Merged

Pr/2230 #2287

merged 5 commits into from
Oct 8, 2020

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented Oct 7, 2020 •
edited
Loading

Editable version of #2230

@ansman
Copy link
Contributor

ansman commented Oct 7, 2020

Now that I think about it it feels weird that singleOrNull ever throws. It feels like it should do what single() does but instead of throwing it returns null.

That is of course a pretty major change in behavior.

@qwwdfsad
Copy link
Collaborator Author

qwwdfsad commented Oct 7, 2020 •
edited
Loading

I've tried to align the implementation with our own singleOrNull implementation. Which is, by mistake, differs from singleOrNull from stdlib which is a major problem as it is.

@qwwdfsad qwwdfsad requested a review from elizarov October 7, 2020 20:50
@qwwdfsad qwwdfsad requested a review from elizarov October 8, 2020 09:09
elizarov
elizarov approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Good to go

@qwwdfsad qwwdfsad merged commit 7897f70 into develop Oct 8, 2020
@qwwdfsad qwwdfsad deleted the pr/2230 branch October 8, 2020 09:50
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
@qwwdfsad @ansman @recheej
Pr/2230 (Kotlin#2287)
e11c4a2 
* Allow nullable types in Flow.firstOrNull
* Allow nullable types in Flow.singleOrNull
* Align Flow.single and Flow.singleOrNull with Kotlin standard library

Fixes Kotlin#2229
Fixes Kotlin#2289

Co-authored-by: Nicklas Ansman Giertz <[email protected]>
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
@qwwdfsad @ansman @recheej
Pr/2230 (Kotlin#2287)
4e687ac 
* Allow nullable types in Flow.firstOrNull
* Allow nullable types in Flow.singleOrNull
* Align Flow.single and Flow.singleOrNull with Kotlin standard library

Fixes Kotlin#2229
Fixes Kotlin#2289

Co-authored-by: Nicklas Ansman Giertz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwarDDay EdwarDDay EdwarDDay left review comments

@ansman ansman ansman approved these changes

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
breaking change For 1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qwwdfsad @ansman @elizarov @EdwarDDay