Skip to content

Provide asFlowable and asObservable by their names in binary instead … #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented Oct 7, 2020

…of 'from' function to prevent naming clash for Java users.

* Do not provide @JvmOverloads for convenience of Java interop
* Deprecate ReceiveChannel.asObservable by the way

Fixes #2182

…of 'from' function to prevent naming clash for Java users.

    * Do not provide @jvmoverloads for convenience of Java interop
    * Deprecate ReceiveChannel.asObservable by the way

Fixes #2182
@qwwdfsad qwwdfsad requested a review from elizarov October 7, 2020 11:11
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great stuff.

@qwwdfsad qwwdfsad merged commit 448106a into develop Oct 8, 2020
@qwwdfsad qwwdfsad deleted the rxconvert-interop branch October 8, 2020 09:01
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
Kotlin#2285)

* Provide asFlowable and asObservable by their names in binary instead of 'from' function to prevent naming clash for Java users.
* Do not provide @jvmoverloads for convenience of Java interop
* Deprecate ReceiveChannel.asObservable by the way

Fixes Kotlin#2182
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
Kotlin#2285)

* Provide asFlowable and asObservable by their names in binary instead of 'from' function to prevent naming clash for Java users.
* Do not provide @jvmoverloads for convenience of Java interop
* Deprecate ReceiveChannel.asObservable by the way

Fixes Kotlin#2182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants