Skip to content

Remove redundant stdlib dependencies #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Remove redundant stdlib dependencies #2253

merged 1 commit into from
Oct 5, 2020

Conversation

turansky
Copy link
Contributor

No description provided.

qwwdfsad
qwwdfsad reviewed Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please ensure that stdlib is still present in POM dependencies in Gradle metadata?

@turansky
Copy link
Contributor Author

Check results:
in POM dependencies - present
in Gradle metadata - present

@qwwdfsad qwwdfsad changed the base branch from develop to kts-transition October 5, 2020 14:54
@qwwdfsad qwwdfsad merged commit c54c326 into Kotlin:kts-transition Oct 5, 2020
qwwdfsad added a commit that referenced this pull request Oct 5, 2020
@qwwdfsad @turansky
Kts transition (#2261)
3af136f 
* Kotlin DSL - 'reactive:reactor'
* Kotlin DSL - 'reactive:jdk9'
* Kotlin DSL - 'kotlinx-coroutines-slf4j'
* Kotlin DSL - 'kotlinx-coroutines-guava'
* Plugin repo management in 'pluginManagement' block
* Remove redundant stdlib dependencies (#2253)

Co-authored-by: Victor Turansky <[email protected]>
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
@qwwdfsad @turansky @recheej
Kts transition (Kotlin#2261)
7de232f 
* Kotlin DSL - 'reactive:reactor'
* Kotlin DSL - 'reactive:jdk9'
* Kotlin DSL - 'kotlinx-coroutines-slf4j'
* Kotlin DSL - 'kotlinx-coroutines-guava'
* Plugin repo management in 'pluginManagement' block
* Remove redundant stdlib dependencies (Kotlin#2253)

Co-authored-by: Victor Turansky <[email protected]>
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
@qwwdfsad @turansky @recheej
Kts transition (Kotlin#2261)
99215ef 
* Kotlin DSL - 'reactive:reactor'
* Kotlin DSL - 'reactive:jdk9'
* Kotlin DSL - 'kotlinx-coroutines-slf4j'
* Kotlin DSL - 'kotlinx-coroutines-guava'
* Plugin repo management in 'pluginManagement' block
* Remove redundant stdlib dependencies (Kotlin#2253)

Co-authored-by: Victor Turansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turansky @qwwdfsad