-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Support JetBrains cache-redirector service for stable CI builds #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,152 @@ | ||
/* | ||
* Copyright 2016-2020 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
|
||
import org.gradle.api.* | ||
import org.gradle.api.artifacts.dsl.* | ||
import org.gradle.api.artifacts.repositories.* | ||
import org.gradle.api.initialization.dsl.* | ||
import java.net.* | ||
|
||
/** | ||
* Enabled via environment variable, so that it can be reliably accessed from any piece of the build script, | ||
* including buildSrc within TeamCity CI. | ||
*/ | ||
private val cacheRedirectorEnabled = System.getenv("CACHE_REDIRECTOR")?.toBoolean() == true | ||
|
||
/** | ||
* The list of repositories supported by cache redirector should be synced with the list at https://cache-redirector.jetbrains.com/redirects_generated.html | ||
* To add a repository to the list create an issue in ADM project (example issue https://youtrack.jetbrains.com/issue/IJI-149) | ||
*/ | ||
private val mirroredUrls = listOf( | ||
"https://cdn.azul.com/zulu/bin", | ||
"https://clojars.org/repo", | ||
"https://dl.bintray.com/d10xa/maven", | ||
"https://dl.bintray.com/groovy/maven", | ||
"https://dl.bintray.com/jetbrains/maven-patched", | ||
"https://dl.bintray.com/jetbrains/scala-plugin-deps", | ||
"https://dl.bintray.com/kodein-framework/Kodein-DI", | ||
"https://dl.bintray.com/konsoletyper/teavm", | ||
"https://dl.bintray.com/kotlin/kotlin-dev", | ||
"https://dl.bintray.com/kotlin/kotlin-eap", | ||
"https://dl.bintray.com/kotlin/kotlinx.html", | ||
"https://dl.bintray.com/kotlin/kotlinx", | ||
"https://dl.bintray.com/kotlin/ktor", | ||
"https://dl.bintray.com/scalacenter/releases", | ||
"https://dl.bintray.com/scalamacros/maven", | ||
"https://dl.bintray.com/kotlin/exposed", | ||
"https://dl.bintray.com/cy6ergn0m/maven", | ||
"https://dl.bintray.com/kotlin/kotlin-js-wrappers", | ||
"https://dl.google.com/android/repository", | ||
"https://dl.google.com/dl/android/maven2", | ||
"https://dl.google.com/dl/android/studio/ide-zips", | ||
"https://dl.google.com/go", | ||
"https://download.jetbrains.com", | ||
"https://jcenter.bintray.com", | ||
"https://jetbrains.bintray.com/dekaf", | ||
"https://jetbrains.bintray.com/intellij-jbr", | ||
"https://jetbrains.bintray.com/intellij-jdk", | ||
"https://jetbrains.bintray.com/intellij-plugin-service", | ||
"https://jetbrains.bintray.com/intellij-terraform", | ||
"https://jetbrains.bintray.com/intellij-third-party-dependencies", | ||
"https://jetbrains.bintray.com/jediterm", | ||
"https://jetbrains.bintray.com/kotlin-native-dependencies", | ||
"https://jetbrains.bintray.com/markdown", | ||
"https://jetbrains.bintray.com/teamcity-rest-client", | ||
"https://jetbrains.bintray.com/test-discovery", | ||
"https://jetbrains.bintray.com/wormhole", | ||
"https://jitpack.io", | ||
"https://maven.pkg.jetbrains.space/kotlin/p/kotlin/dev", | ||
"https://maven.pkg.jetbrains.space/kotlin/p/kotlin/bootstrap", | ||
"https://maven.pkg.jetbrains.space/kotlin/p/kotlin/eap", | ||
"https://kotlin.bintray.com/dukat", | ||
"https://kotlin.bintray.com/kotlin-dependencies", | ||
"https://oss.sonatype.org/content/repositories/releases", | ||
"https://oss.sonatype.org/content/repositories/snapshots", | ||
"https://oss.sonatype.org/content/repositories/staging", | ||
"https://packages.confluent.io/maven/", | ||
"https://plugins.gradle.org/m2", | ||
"https://plugins.jetbrains.com/maven", | ||
"https://repo1.maven.org/maven2", | ||
"https://repo.grails.org/grails/core", | ||
"https://repo.jenkins-ci.org/releases", | ||
"https://repo.maven.apache.org/maven2", | ||
"https://repo.spring.io/milestone", | ||
"https://repo.typesafe.com/typesafe/ivy-releases", | ||
"https://services.gradle.org", | ||
"https://www.exasol.com/artifactory/exasol-releases", | ||
"https://www.myget.org/F/intellij-go-snapshots/maven", | ||
"https://www.myget.org/F/rd-model-snapshots/maven", | ||
"https://www.myget.org/F/rd-snapshots/maven", | ||
"https://www.python.org/ftp", | ||
"https://www.jetbrains.com/intellij-repository/nightly", | ||
"https://www.jetbrains.com/intellij-repository/releases", | ||
"https://www.jetbrains.com/intellij-repository/snapshots" | ||
) | ||
|
||
private val aliases = mapOf( | ||
"https://repo.maven.apache.org/maven2" to "https://repo1.maven.org/maven2", // Maven Central | ||
"https://kotlin.bintray.com/kotlin-dev" to "https://dl.bintray.com/kotlin/kotlin-dev", | ||
"https://kotlin.bintray.com/kotlin-eap" to "https://dl.bintray.com/kotlin/kotlin-eap", | ||
"https://kotlin.bintray.com/kotlinx" to "https://dl.bintray.com/kotlin/kotlinx" | ||
) | ||
|
||
private fun URI.toCacheRedirectorUri() = URI("https://cache-redirector.jetbrains.com/$host/$path") | ||
|
||
private fun URI.maybeRedirect(): URI? { | ||
val url = toString().trimEnd('/') | ||
val dealiasedUrl = aliases.getOrDefault(url, url) | ||
|
||
return if (mirroredUrls.any { dealiasedUrl.startsWith(it) }) { | ||
URI(dealiasedUrl).toCacheRedirectorUri() | ||
} else { | ||
null | ||
} | ||
} | ||
|
||
private fun URI.isCachedOrLocal() = scheme == "file" || | ||
host == "cache-redirector.jetbrains.com" || | ||
host == "teamcity.jetbrains.com" || | ||
host == "buildserver.labs.intellij.net" | ||
|
||
private fun Project.checkRedirectUrl(url: URI, containerName: String): URI { | ||
val redirected = url.maybeRedirect() | ||
if (redirected == null && !url.isCachedOrLocal()) { | ||
val msg = "Repository $url in $containerName should be cached with cache-redirector" | ||
val details = "Using non cached repository may lead to download failures in CI builds." + | ||
" Check buildSrc/src/main/kotlin/CacheRedirector.kt for details." | ||
logger.warn("WARNING - $msg\n$details") | ||
} | ||
return if (cacheRedirectorEnabled) redirected ?: url else url | ||
} | ||
|
||
private fun Project.checkRedirect(repositories: RepositoryHandler, containerName: String) { | ||
if (cacheRedirectorEnabled) { | ||
logger.info("Redirecting repositories for $containerName") | ||
} | ||
for (repository in repositories) { | ||
when (repository) { | ||
is MavenArtifactRepository -> repository.url = checkRedirectUrl(repository.url, containerName) | ||
is IvyArtifactRepository -> repository.url = checkRedirectUrl(repository.url, containerName) | ||
} | ||
} | ||
} | ||
|
||
// Used from Groovy scripts | ||
object CacheRedirector { | ||
/** | ||
* Substitutes repositories in buildScript { } block. | ||
*/ | ||
@JvmStatic | ||
fun ScriptHandler.configureBuildScript(rootProject: Project) { | ||
rootProject.checkRedirect(repositories, "${rootProject.displayName} buildscript") | ||
} | ||
|
||
/** | ||
* Substitutes repositories in a project. | ||
*/ | ||
@JvmStatic | ||
fun Project.configure() { | ||
checkRedirect(repositories, displayName) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nobody will see this warning until builds start to fail.
Maybe a better strategy is to fail-fast, so the maintainer (this script is going to be copy-pasted :)) will see the failure, file an issue and mute the problem only then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a test, so the only thing I can do is to hard-fail here, which is too much. I've tried doing it as a test (that's what
kotlin
project does), but that turned out to be quite complicated due to various technical issues, since I want to verify repositories in all projects and buildscript.