Skip to content

Provide way to dedup function calls #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

recheej
Copy link
Contributor

@recheej recheej commented Sep 7, 2020

Resolves #1097.

I think naming can def change. Open to suggestions. Let me know what you think for API. Btw, how do you update kotlinx-coroutines-core.api?

@elizarov
Copy link
Contributor

elizarov commented Sep 7, 2020

You are proposing to add some quite massing public API without any docs. It does not work this way. Can you, please, start by explaining the design goals of this PR. What exact problem does it solve? How generic it is? Why it has to add some new public classes to the API?

@recheej
Copy link
Contributor Author

recheej commented Sep 7, 2020

@elizarov sure I can provide more documentation. First, it should be known that I'm trying to replicate api from go as mentioned in the issue. But sounds like you maybe have issue with new public classes? Mind giving me your thoughts there before I go adding all this documentation to this public class that may be remove in the end?

@recheej recheej closed this Sep 7, 2020
@recheej recheej deleted the dedupfunctioncalls branch September 7, 2020 15:28
@recheej
Copy link
Contributor Author

recheej commented Sep 7, 2020

Closing issue as it's required by maintainers that things like this come with a design write up. While I understand the need it's too much investment for me right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants