Skip to content

Release coroutine block after lazy start #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Release coroutine block after lazy start #2111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba6e4c2
Release coroutine block after lazy start
1zaman Jun 29, 2020
45a85ef
Clear reference before invoking the Continuation
1zaman Jun 29, 2020
3a55cee
Remove exclamation mark from error messages
1zaman Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions kotlinx-coroutines-core/common/src/Builders.common.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,11 @@ private class LazyDeferredCoroutine<T>(
parentContext: CoroutineContext,
block: suspend CoroutineScope.() -> T
) : DeferredCoroutine<T>(parentContext, active = false) {
private val continuation = block.createCoroutineUnintercepted(this, this)
private var continuation: Continuation<Unit>? = block.createCoroutineUnintercepted(this, this)

override fun onStart() {
val continuation = checkNotNull(this.continuation) { "Already started" }
this.continuation = null
continuation.startCoroutineCancellable(this)
}
}
Expand Down Expand Up @@ -195,9 +197,11 @@ private class LazyStandaloneCoroutine(
parentContext: CoroutineContext,
block: suspend CoroutineScope.() -> Unit
) : StandaloneCoroutine(parentContext, active = false) {
private val continuation = block.createCoroutineUnintercepted(this, this)
private var continuation: Continuation<Unit>? = block.createCoroutineUnintercepted(this, this)

override fun onStart() {
val continuation = checkNotNull(this.continuation) { "Already started" }
this.continuation = null
continuation.startCoroutineCancellable(this)
}
}
Expand Down