Fix typos #2098
Closed
Fix typos #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
Jun 22, 2020
| @@ -428,19 +428,19 @@ fun main() = runBlocking { | |||
| supervisorScope { | |||
| val child = launch { | |||
| try { | |||
| println("Child is sleeping") | |||
| println("The child is sleeping") | |||
There was a problem hiding this comment.
Please also run ./gradlew knit to update actual .kt files
There was a problem hiding this comment.
It doesn't work, it says JDK_16 environment variable is not defined.
There was a problem hiding this comment.
It's really, really sad that I would have to install JDK 1.6 just to have some typos fixed :(
There was a problem hiding this comment.
If the "Allow modifications from maintainers" checkbox is checked, maybe @qwwdfsad can do it?
LouisCAD
reviewed
Jun 22, 2020
Co-authored-by: Louis CAD <[email protected]>
Closed
elizarov
pushed a commit
that referenced
this pull request
Jul 3, 2020
Co-authored-by: Louis CAD <[email protected]>
|
Thanks. I've run knit and merged manually via f4fb204 Btw, for the purposes of knit you can simply set JDK_16 to JDK_HOME. I'll see if I can patch the code to make it happen automatically. |
|
Thank you, Roman! |
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
Co-authored-by: Louis CAD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.