Skip to content

Improve grammar in docs/Basics #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Improve grammar in docs/Basics #2076

wants to merge 3 commits into from

Conversation

medavox
Copy link
Contributor

@medavox medavox commented Jun 2, 2020

This is just a few small corrections to some minor second-language grammar mistakes; also improving readability and punctuation in a few places.

I've also replaced the phrase 'get full code here' with 'get the full code here', because that sounds more natural to me. But Englishes do differ, and is a very minor thing anyway. I understand this is a pretty ubiquitous phrase, and I've only changed it in this one document, so I've kept those changes in a separate commit so you can reject them (and keep the others) if you don't think that's a worthwhile change.

@elizarov elizarov self-requested a review June 2, 2020 10:44
@elizarov elizarov self-assigned this Jun 2, 2020
@elizarov
Copy link
Contributor

elizarov commented Jun 2, 2020

Thanks a lot. Indeed, that the full code reads better. Can you then, please, search & replace for it in all *.md files in docs folder for consistency and add to this PR, too.

@medavox
Copy link
Contributor Author

medavox commented Jun 2, 2020

OK, will do.

@medavox
Copy link
Contributor Author

medavox commented Jun 2, 2020

Done. I'm still reading the guide and learning how to use coroutines, so there may be further proofreading commits to come, but there may not. No promises.

elizarov pushed a commit that referenced this pull request Jun 3, 2020
@elizarov
Copy link
Contributor

elizarov commented Jun 3, 2020

Thanks. I've merged it into master with a couple of corrections (consistent the runBlocking and added docs link to the coroutineScope function mention).

@elizarov elizarov closed this Jun 3, 2020
@medavox
Copy link
Contributor Author

medavox commented Jun 3, 2020

thanks!

@elizarov elizarov mentioned this pull request Jul 16, 2020
1 task
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants