Refactor mpp/native build, introduce "concurrent" source set, test launcher #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
force-pushed
the
mpp-concurrent-build
branch
2 times, most recently
from
c1b3d70 to
b10740b
Compare
|
Fixed import to IDEA, so that it now resolves properly in IDEA. |
qwwdfsad
requested changes
Jun 2, 2020
| fun mainBackground(args: Array<String>) { | ||
| val worker = Worker.start(name = "main-background") | ||
| worker.execute(TransferMode.SAFE, { args.freeze() }) { | ||
| val result = testLauncherEntryPoint(it) |
There was a problem hiding this comment.
testLauncherEntryPoint is K/N internal API to run tests, right?
| // Test for memory leaks using a special entry point that does not exit but returns from main | ||
| binaries.getTest("DEBUG").freeCompilerArgs += ["-e", "kotlinx.coroutines.mainNoExit"] | ||
| // Configure a separate test where code runs in background | ||
| test("background", [org.jetbrains.kotlin.gradle.plugin.mpp.NativeBuildType.DEBUG]) { |
There was a problem hiding this comment.
Why it is not possible to use -trw flag instead of hand-rolled implementation?
There was a problem hiding this comment.
It does not have CFRunLoopRun in the main thread, thus attempts to dispatch tasks to the main thread from -trw will hang.
|
I've also added additional workarounds to improve IDE experience under 1.4. It is not ideal under 1.4 (platform declaration like |
LouisCAD
reviewed
Jun 3, 2020
kotlinx-coroutines-core/build.gradle
Outdated
| def implementationConfiguration = configurations[hostMainCompilation.defaultSourceSet.implementationMetadataConfigurationName] | ||
| // Now find the libraries: | ||
| // Kotlin 1.3.x: Find all platform libs | ||
| // Kotlin 1.4.x: Finds platform libs & stdlib, but platform declarations are still not resolved due to IDE bugs |
There was a problem hiding this comment.
Do we have the links to these bugs to allow future reviews to check if they are resolved? If so, it'd be nice to add extra comment lines for them IMO.
There was a problem hiding this comment.
They will be fixed before 1.4 release and affect only HMPP projects anyway.
qwwdfsad
approved these changes
Aug 8, 2020
…uncher New source sets: * "concurrent" source set is shared between "jvm" and "native" * "native" source set is subdivided into "nativeDarwin" (Apple) and "nativeOther" (Linux, etc) Native tests are launched in two variants: * A default "test" task runs tests with memory leak checker from "mainNoExit" entry point. * A special "backgroundTest" task runs tests in a background worker from "mainBackground" entry point. Other build improvement: * Modernize old-style IDEA-active hacks to kts helper. * Extract versions of JS test runner dependencies. * Remove redundant google repo reference from android tests.
elizarov
force-pushed
the
mpp-concurrent-build
branch
2 times, most recently
from
fc1845c to
af4a9d1
Compare
elizarov
force-pushed
the
mpp-concurrent-build
branch
from
af4a9d1 to
13e6757
Compare
|
I've dropped hacks for 1.3.x and enabled HPMM. Now need to figure out why tests with workers don't pass under K/N. |
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
…uncher (Kotlin#2074) New source sets: * "concurrent" source set is shared between "jvm" and "native" * "native" source set is subdivided into "nativeDarwin" (Apple) and "nativeOther" (Linux, etc) Native tests are launched in two variants: * A default "test" task runs tests with memory leak checker from "mainNoExit" entry point. * A special "backgroundTest" task runs tests in a background worker from "mainBackground" entry point. Other build improvement: * Modernize old-style IDEA-active hacks to kts helper. * Extract versions of JS test runner dependencies. * Remove redundant google repo reference from android tests.
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
…uncher (Kotlin#2074) New source sets: * "concurrent" source set is shared between "jvm" and "native" * "native" source set is subdivided into "nativeDarwin" (Apple) and "nativeOther" (Linux, etc) Native tests are launched in two variants: * A default "test" task runs tests with memory leak checker from "mainNoExit" entry point. * A special "backgroundTest" task runs tests in a background worker from "mainBackground" entry point. Other build improvement: * Modernize old-style IDEA-active hacks to kts helper. * Extract versions of JS test runner dependencies. * Remove redundant google repo reference from android tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor mpp/native build, introduce "concurrent" source set, test launcher
New source sets:
Native tests are launched in two variants:
Other build improvement: