Flow.transformWhile operator #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwarDDay
reviewed
May 28, 2020
qwwdfsad
requested changes
Jun 22, 2020
| internal suspend inline fun <T> Flow<T>.collectWhile(crossinline predicate: suspend (value: T) -> Boolean) { | ||
| val collector = object : FlowCollector<T> { | ||
| override suspend fun emit(value: T) { | ||
| if (!predicate(value)) throw AbortFlowException(this) |
There was a problem hiding this comment.
Let's move throw to the separate line:
if (!predicate(value)) {
throw AbortFlowException(this)
}
It would make other people debugging experience a bit better (they can put a breakpoint on throw)
Also, all flow-truncating operators are refactored via a common internal collectWhile operator that properly uses AbortFlowException and checks for its ownership, so that we don't have to look for bugs in interactions between all those operators (and zip, too, which is also flow-truncating). Fixes #2065
Co-authored-by: EdwarDDay <[email protected]>
* Restore fast tail-call impl for take * Benchmark for takeWhile * Test flow invariants for takeWhile
elizarov
force-pushed
the
flow-transform-while
branch
from
b9c352c to
fdd724d
Compare
qwwdfsad
approved these changes
Jul 15, 2020
| (0L..Long.MAX_VALUE).asFlow().takeWhileViaCollectWhile { it < size }.consume() | ||
| } | ||
|
|
||
| // Direct implemenatation by checking predicate and throwing AbortFlowException |
LouisCAD
reviewed
Jul 16, 2020
benchmarks/src/jmh/kotlin/benchmarks/flow/TakeWhileBenchmark.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Louis CAD <[email protected]>
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
Also, most flow-truncating operators are refactored via a common internal collectWhile operator that properly uses AbortFlowException and checks for its ownership, so that we don't have to look for bugs in interactions between all those operators (and zip, too, which is also flow-truncating). But `take` operator still users a custom highly-tuned implementation. Fixes Kotlin#2065 Co-authored-by: EdwarDDay <[email protected]> Co-authored-by: Louis CAD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, all flow-truncating operators are refactored via a common internal collectWhile operator that properly uses AbortFlowException and checks for its ownership, so that we don't have to look for bugs in interactions between all those operators (and zip, too, which is also flow-truncating).
Fixes #2065