Fixes for 1.4-M2 & HMPP #2031
Merged
Fixes for 1.4-M2 & HMPP #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
May 18, 2020
|
Also, please revert changes in |
* Rename the JVM module: empty suffix -> '-jvm'; * Rename the root MPP module: '-native' -> empty suffix; * Publish the JVM JAR and POM in the root MPP module, so that consumers who can't read Gradle module metadata, such as Maven or old Gradle versions, get the JVM resolution result from the root MPP module.
Otherwise variant-aware resolution fails to find compatible variant in kotlinx-coroutines-core
recheej
pushed a commit
to recheej/kotlinx.coroutines
that referenced
this pull request
Dec 28, 2020
* Gradle 6.3 * Enable Gradle module metadata in all modules * Workaround for gradle/gradle#11412 * Fix invalid mutation of a tasks's dependsOn w/Gradle 6.3 * Rename root MPP module and publish the JVM JAR within * Rename the JVM module: empty suffix -> '-jvm'; * Rename the root MPP module: '-native' -> empty suffix; * Publish the JVM JAR and POM in the root MPP module, so that consumers who can't read Gradle module metadata, such as Maven or old Gradle versions, get the JVM resolution result from the root MPP module. * Enable HMPP * Add jvm attribute to detached configuration Otherwise variant-aware resolution fails to find compatible variant in kotlinx-coroutines-core * Enable HMPP conditionally for Kotlin 1.4.x and not 1.3.7x * Workaround KT-39037 * Disable PrecompiledDebugProbesTest test in train builds * Conditionally hack out the Gradle module metadata with Kotlin 1.3.7x * Conditionally rename Kotlin metadata module to *-metadata with Kotlin 1.4.x * Conditionally rename the root & JVM modules with Kotlin 1.4.x Co-authored-by: Dmitry Savvinov <[email protected]> Co-authored-by: Vsevolod Tolstopyatov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.