Skip to content

Flow cancellation #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2020
Merged

Flow cancellation #2028

merged 4 commits into from
May 18, 2020

Conversation

qwwdfsad
Copy link
Collaborator

No description provided.

qwwdfsad added 2 commits May 14, 2020 16:28
    * flow builder is cancellable by default
    * New unambiguous currentContext top-level function
    * New Flow.cancellable() operator
    * Set of lint to catch programmer's errors in compile time

Fixes #2026
@qwwdfsad qwwdfsad requested a review from elizarov May 14, 2020 16:08
@qwwdfsad qwwdfsad requested a review from elizarov May 15, 2020 09:25
@qwwdfsad qwwdfsad force-pushed the flow-cancellation branch from 823d60a to 2f87fe4 Compare May 15, 2020 09:34
@qwwdfsad qwwdfsad force-pushed the flow-cancellation branch from 23fb146 to c75d834 Compare May 18, 2020 09:03
@qwwdfsad qwwdfsad merged commit 5a20585 into develop May 18, 2020
@qwwdfsad qwwdfsad deleted the flow-cancellation branch May 18, 2020 09:31
elizarov added a commit that referenced this pull request May 21, 2020
* Remove outdated phrase on "flow infrastructure does not introduce additional cancellation points". They were introduced by #2028
* Add a section on "Flow cancellation check" with examples on `Flow.cancellable()`` operator.
* Add a bit more detail in `flow` and `cancellable` docs with links to `ensureActive()`.
elizarov added a commit that referenced this pull request Jun 3, 2020
* Improve the docs and guide on flow cancellation
* Remove outdated phrase on "flow infrastructure does not introduce additional cancellation points". They were introduced by #2028
* Add a section on "Flow cancellation check" with examples on `Flow.cancellable()`` operator.
* Add a bit more detail in `flow` and `cancellable` docs with links to `ensureActive()`.
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
Make Flow more cancellation friendly:

    * flow builder is cancellable by default
    * New unambiguous currentCoroutineContext top-level function
    * New Flow.cancellable() operator

Fixes Kotlin#2026
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
* Improve the docs and guide on flow cancellation
* Remove outdated phrase on "flow infrastructure does not introduce additional cancellation points". They were introduced by Kotlin#2028
* Add a section on "Flow cancellation check" with examples on `Flow.cancellable()`` operator.
* Add a bit more detail in `flow` and `cancellable` docs with links to `ensureActive()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants