-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Support thread interrupting blocking functions (#1947) #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Amended as #1947:
|
#1947 (comment) Thanks a lot for your valuable contribution and moving this almost abandoned issue forward! |
@qwwdfsad The design seems sweet. Especially as with avoid cross-block (launch...) misuse. Thanks a lot for you to finally make coroutine together with interruption possible. That really helps a lot at least for some common Android patterns as I could see and make some people's work easy. I'd like to help complete this helpful progress. |
I added DSL restriction just now with a draft commit (didn't amend the previous one). I found this DSL restriction may break existing code, as I commented as a code review comment for an example. Existing code may need change to use explicit reference to outer scope in this situation. Is that expected or is there something I missed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding DSL restrictions, it is actually my oversight and it seems to be impossible to achieve desired behaviour. One more task for refining DslMarker :)
Please just get rid of it (scope receiver, new interfaces, dsl annotations), let's fallback to the original plan.
This is implementation of issue Kotlin#1947 Signed-off-by: Trol <[email protected]>
@qwwdfsad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the high-quality contribution!
I've slightly adjusted it (mostly documentation and the code style we prefer) and opened #1972.
Will merge it soon if you don't have any objections
Thanks. Glad to see that. |
Merged via #1972. |
This is implementation of issue
#57#1947 and non-intrusive variant of #1922Signed-off-by: Trol [email protected]