Fix race in channel select/cancel #1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was introduced by PR #1524. It was reproducing when there is a regular "send" operation on one side of a channel and "select { onReceive }" on another side of the channel and the "send" coroutine gets cancelled. The problem is that SendElement.tryResumeSend implementation was calling finishPrepare before it has successfully resumed continuation, so if that continuation was already cancelled, the code in "finishPrepare" had already stored the wrong affected node which it would later try to call "completeResume" on. This patch also adds hexAddress to the debug toString method of all internal node classes in channel implementation. Fixes #1588
qwwdfsad
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced by PR #1524. It was reproducing when there
is a regular "send" operation on one side of a channel and
"select { onReceive }" on another side of the channel and the
"send" coroutine gets cancelled. The problem is that
SendElement.tryResumeSend implementation was calling finishPrepare
before it has successfully resumed continuation, so if that
continuation was already cancelled, the code in "finishPrepare" had
already stored the wrong affected node which it would later try to
call "completeResume" on.
This patch also adds hexAddress to the debug toString method of
all internal node classes in channel implementation.
Fixes #1588