Skip to content

Promote reactive bridges for Flow to stable API #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2019
Merged

Promote reactive bridges for Flow to stable API #1549

merged 3 commits into from
Sep 19, 2019

Conversation

qwwdfsad
Copy link
Collaborator

No description provided.

@qwwdfsad qwwdfsad requested a review from elizarov September 17, 2019 16:04
elizarov
elizarov suggested changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also include others:

  • Flow.asFlowable()
  • Flow.asObservable() + warning on obsolete asObservable(context)
  • the other converters from RxConvert.kt
    what do you think?

@qwwdfsad
Copy link
Collaborator Author

Flow.asFlowable() -- looks reasonable, it piggybacks on asPublisher anyway.
Flow.asObservable() -- not really, I am not happy with the implementation (even though each choice in the implementation is properly tested). I'd rather wait for demand on this API to become stable before promoting it.
RxConvert.kt -- the same story. I am not sure if these extensions are useful at all.

@qwwdfsad qwwdfsad requested a review from elizarov September 19, 2019 12:30
@qwwdfsad qwwdfsad merged commit 835ed4d into develop Sep 19, 2019
@qwwdfsad qwwdfsad deleted the rx-flow-stable branch March 6, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @elizarov