Skip to content

Do not report already handled exception in select builder #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2019
Merged

Do not report already handled exception in select builder #1436

merged 1 commit into from
Aug 14, 2019

Conversation

qwwdfsad
Copy link
Collaborator

Fixes #1433

@qwwdfsad qwwdfsad force-pushed the select-exception-reporting branch from 04a98ae to a84575c Compare August 12, 2019 12:02
@Thomas-Vos
Copy link
Contributor

Hey, thank you every much for the fix. I tried it out in my project and can confirm the bug is gone now.

elizarov
elizarov approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qwwdfsad qwwdfsad merged commit 64902a9 into develop Aug 14, 2019
@qwwdfsad qwwdfsad deleted the select-exception-reporting branch August 14, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwwdfsad @Thomas-Vos @elizarov