Skip to content

Use setTimeout-based dispatcher when process is not available on the … #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2019
Merged

Use setTimeout-based dispatcher when process is not available on the … #1409

merged 2 commits into from
Aug 5, 2019

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented Aug 5, 2019

…target runtime

Fixes #1404

@qwwdfsad qwwdfsad requested a review from elizarov August 5, 2019 10:15
elizarov
elizarov suggested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, get rid of NodeJsMessageQueue and SetTimeoutMessageQueue objects by pulling the queue inside of SetTimeoutBasedDispatcher is a similar way to WindowDispatcher.

elizarov
elizarov approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@qwwdfsad qwwdfsad merged commit 2fc234c into develop Aug 5, 2019
@qwwdfsad qwwdfsad deleted the js-dispatcher branch August 5, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @elizarov