Fully copy CoroutineInfo for DebugProbes.dumpCoroutinesInfo, it is re… #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quired for IDEA integration (field is left as internal deliberately)
qwwdfsad
force-pushed
the
debug-agent-idea-fix
branch
from
4757879 to
14fa5a7
Compare
elizarov
suggested changes
Jul 23, 2019
There was a problem hiding this comment.
Looks fragile, as the automatically-generated copy() still does not copy the thread info and this parameter-less one does. Please, either override automatically generated copy (add two optional parameters to the copy) or make the thread a part of data-class state.
|
I've decided to make |
qwwdfsad
force-pushed
the
debug-agent-idea-fix
branch
from
4d5e2e0 to
80c8054
Compare
elizarov
suggested changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…quired for IDEA integration (field is left as internal deliberately)