Add Flow.onStart, support emit in onCompletion #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
force-pushed
the
flow-transform-safety
branch
from
a8e4da4 to
6610acc
Compare
elizarov
force-pushed
the
flow-transform-safety
branch
from
6610acc to
a77d713
Compare
* All "emitting" operators (onStart, transform, onCompletion) are moved to Emitter * All transformations in Transform.kt are rewritten via (unsafe) transforms, but all of (safe) transform, onStart and onCompletion operators collectors are safe. * Added migration for startWith and concatWith. * Consistent docs for all migration functions. * JvmMultifileClass for Migration.kt so that renamed/deprecated functions (when they moved there) continue to resolve. Fixes #1168
elizarov
force-pushed
the
flow-transform-safety
branch
from
a77d713 to
5cf7796
Compare
qwwdfsad
approved these changes
Jul 17, 2019
kotlinx-coroutines-core/common/test/flow/operators/OnStartTest.kt
Outdated
Show resolved
Hide resolved
kotlinx-coroutines-core/common/test/flow/operators/TransformTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Flow.onStart, support emit in onCompletion
to Emitters.kt and are implemented in a safe way, making sure that
user-specified block is called on a SafeCollector only.
functions (when they moved there) continue to resolve.
Fixes #1168