Consume as flow #1343
Merged
Consume as flow #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
force-pushed
the
consume-as-flow
branch
from
bc34a2e to
f116346
Compare
qwwdfsad
requested changes
Jul 16, 2019
kotlinx-coroutines-core/common/test/flow/channels/ChannelBuildersFlowTest.kt
Outdated
Show resolved
Hide resolved
elizarov
force-pushed
the
consume-as-flow
branch
from
f116346 to
bb4a835
Compare
qwwdfsad
requested changes
Jul 17, 2019
| * 1) Flow consumer is cancelled when the original channel is cancelled. | ||
| * 2) Flow consumer completes normally when the original channel completes (~is closed) normally. | ||
| * 3) If the flow consumer fails with an exception, channel is cancelled. | ||
| * |
romansl
reviewed
Jul 17, 2019
elizarov
force-pushed
the
consume-as-flow
branch
4 times, most recently
from
d5e12d2 to
e54272b
Compare
|
I've squashed and rearranged all the old commit into two logically grouped commits, fixing all the review issues:
I've added a 3rd (new) commit that makes |
* The corresponding ReceiveChannel methods are deprecated.
* Introduced corresponding extensions with the same semantic and generic
Any bound.
* Introduce internal ReceiveChannel.[on]receiveOrClosed
* Using internal inline class ValueOrClosed.
* To be stabilized and made public in the future when inline classes
ABI stabilizes.
* It is related to #330 but does not resolve it yet.
* Includes todos for future public ValueOrClose design.
* Simplify AbstractChannel select implementations.
* AbstractChannel implementation is optimized to avoid code
duplication in suspension of different receive methods:
receive, receiveOrNull, receiveOrClosed.
* This is a consuming conversion -- the resulting flow can be collected just once and the channel is closed after the first collect. * The implementation is made efficient via emitAll extension. * Experimental FlowCollector.emitAll extension is introduced. * It is based on the (internal) Channel.receiveOrClose and ensures that the reference to the last emitted value is not retained (does not leak). Fixes #1340 Fixes #1333
elizarov
force-pushed
the
consume-as-flow
branch
from
e54272b to
d8a87f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just once and the channel is closed after the first collect.
a new internal ReceiveChannel.consumeEachTo function which also ensure
that the reference to the last emitted value is not retained.
in different receive methods.