Context passing between coroutines and Reactor Mono/Flux #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Apr 30, 2019
| private const val SIGNALLED = -2L // already signalled subscriber onCompleted/onError | ||
|
|
||
| @Suppress("CONFLICTING_JVM_DECLARATIONS", "RETURN_TYPE_MISMATCH_ON_INHERITANCE") | ||
| private class PublisherCoroutine<in T>( |
There was a problem hiding this comment.
Copy-pasting the whole integration is definitely not an option: it is hard to maintain, hard to test and easy to mess up.
For example, we can make it public and mark with InternalCoroutinesApi
| ): Flux<T> = Flux.from(reactorPublish(newCoroutineContext(context), block = block)) | ||
|
|
||
| @ExperimentalCoroutinesApi | ||
| public fun <T> CoroutineScope.reactorPublish( |
There was a problem hiding this comment.
Why do we have to introduce public reactorPublish API?
Integration should work with flux builder.
|
|
||
| class ReactorContextTest { | ||
| @Test | ||
| fun monoHookedContext() = runBlocking(Context.of(1, "1", 7, "7").asCoroutineContext()) { |
There was a problem hiding this comment.
code style: all our tests are started with test prefix
qwwdfsad
reviewed
May 8, 2019
qwwdfsad
requested changes
Jul 16, 2019
SokolovaMaria
force-pushed
the
reactor-context
branch
2 times, most recently
from
90cb996 to
ff06d83
Compare
SokolovaMaria
force-pushed
the
reactor-context
branch
from
ff06d83 to
2fa8ee9
Compare
qwwdfsad
force-pushed
the
reactor-context
branch
from
67f7971 to
c2fd09f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.