Skip to content

Fix atomicfu post-processing and dependencies #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2019
Merged

Fix atomicfu post-processing and dependencies #1120

merged 1 commit into from
Apr 21, 2019

Conversation

elizarov
Copy link
Contributor

@elizarov elizarov commented Apr 19, 2019 •
edited
Loading

  • Update to atomicfu 0.12.4, which fixes plugin operation with
    kotlin-multiplatform
  • Remove explicit dependencies (plugins adds them automatically)
  • There will be no atomicfu dependency in the resulting artefacts

Fixes #1116
Fixes #1064

@elizarov elizarov requested a review from qwwdfsad April 19, 2019 16:08
@elizarov elizarov mentioned this pull request Apr 20, 2019
Closed
caarmen added a commit to caarmen/poet-assistant that referenced this pull request Apr 21, 2019
@caarmen
Add hack for Kotlin/kotlinx.coroutines#1120
603690c
@elizarov
Fix atomicfu post-processing and dependencies
6695746 
* Update to atomicfu 0.12.4, which fixes plugin operation with
  kotlin-multiplatform
* Remove explicit dependencies (plugins adds them automatically)

Fixes #1116
Fixes #1064
@elizarov elizarov merged commit e1ac2e5 into develop Apr 21, 2019
@elizarov elizarov deleted the atomicfu-fix branch April 21, 2019 15:52
@steve-the-edwards
Copy link
Contributor

steve-the-edwards commented May 29, 2019 •
edited
Loading

I am still getting this Gradle Plugin error:

kotlinx.atomicfu.AtomicFU: can't find referenced method 'void setInterceptor(kotlinx.atomicfu.AtomicOperationInterceptor)' in program class kotlinx.atomicfu.InterceptorKt

This is while using kotlinx-coroutines-core and kotlinx-coroutines-android in both shared Kotlin library included as .aar and in application project itself.

I tried explicit includes like the following:

implementation "org.jetbrains.kotlinx:kotlinx-serialization-runtime:$serialization_version"
    implementation "org.jetbrains.kotlinx:atomicfu:0.12.4"
    implementation "org.jetbrains.kotlinx:atomicfu-common:0.12.4"
    implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.2.1"
    implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.2.1'

Still no luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elizarov @steve-the-edwards @qwwdfsad