Skip to content

Amortize the cost of coroutine dispatch using message queue in all JS… #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2019
Merged

Amortize the cost of coroutine dispatch using message queue in all JS… #1027

merged 1 commit into from
May 31, 2019

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Mar 5, 2019 •
edited
Loading

… dispatchers.

Use Promise.resolve and process.nextTick as dispatch mechanism for cold starts.

Fixes #820

Corresponding benchmarks is not part of this PR until Kotlin/kotlinx-benchmark#4 is integrated

@qwwdfsad
Amortize the cost of coroutine dispatch using message queue in all JS…
d648280 
… dispatchers.

Use Promise.resolve and process.nextTick as dispatch mechanism for cold starts
@qwwdfsad qwwdfsad requested a review from elizarov March 5, 2019 11:59
@qwwdfsad
Copy link
Member Author

qwwdfsad commented Mar 5, 2019

Build is actually successful: https://teamcity.jetbrains.com/viewType.html?buildTypeId=KotlinTools_KotlinxCoroutines_BuildAggregated&branch_KotlinTools_KotlinxCoroutines=js-dispatcher&tab=buildTypeStatusDiv

@qwwdfsad qwwdfsad force-pushed the develop branch 4 times, most recently from 1837412 to 1748ce1 Compare April 18, 2019 11:49
elizarov
elizarov approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@qwwdfsad qwwdfsad merged commit b7e1499 into develop May 31, 2019
@qwwdfsad qwwdfsad deleted the js-dispatcher branch May 31, 2019 10:25
@webleaf webleaf mentioned this pull request Aug 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @elizarov