Skip to content

Improve stacktrace merge heuristic: skip state machine meaningless fr… #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 22, 2019

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented Mar 1, 2019

…ame when attempting to merge stacktraces

Use timeout in all tests

@qwwdfsad qwwdfsad force-pushed the debugger-sm-bypass branch from e1e2628 to e35baa4 Compare March 5, 2019 15:27
@qwwdfsad qwwdfsad marked this pull request as ready for review March 5, 2019 15:43
@qwwdfsad qwwdfsad requested a review from elizarov March 5, 2019 15:43
@qwwdfsad qwwdfsad force-pushed the debugger-sm-bypass branch 2 times, most recently from 11552be to c099090 Compare March 6, 2019 11:40
@qwwdfsad qwwdfsad requested a review from elizarov March 6, 2019 11:41
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@qwwdfsad qwwdfsad requested a review from elizarov March 13, 2019 16:16
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  * Rename jobOrNull to job
  * Replace coroutine with its context
  * Add check-and-act on isInstalled flag into synchronized blocks in order to avoid spurious memory leaks during uninstall
  * Replace WeakHashMap with Set to simplify debug probes
@qwwdfsad qwwdfsad force-pushed the debugger-sm-bypass branch from 1829111 to 2496dc2 Compare March 22, 2019 14:09
# Conflicts:
#	kotlinx-coroutines-core/common/src/Timeout.kt
@qwwdfsad qwwdfsad merged commit 4ebc130 into develop Mar 22, 2019
@qwwdfsad qwwdfsad deleted the debugger-sm-bypass branch March 22, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants