Skip to content

Possible legacy example #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LouisCAD opened this issue Nov 6, 2018 · 1 comment
Closed

Possible legacy example #803

LouisCAD opened this issue Nov 6, 2018 · 1 comment
Assignees
@qwwdfsad

Comments

@LouisCAD
Copy link
Contributor

LouisCAD commented Nov 6, 2018

Multiple possible problems in this snippet of the documentation:

kotlinx.coroutines/common/kotlinx-coroutines-core-common/src/CoroutineScope.kt

Line 136 in 00d86c5

* suspend fun loadDataForUI() = coroutineScope {

  1. Uses UI instead of Dispatchers.Main
  2. Unsure if showcasing an example with async is the best choice (I may be wrong on this).
qwwdfsad added a commit that referenced this issue Nov 14, 2018
@qwwdfsad
Update documentation in favor of Dispatchers.Main
a88f628 
Fixes #803
Fixes #802
@elizarov
Copy link
Contributor

@qwwdfsad We need to merge this particular documentation-fixing commit from your postponed branch.

@elizarov elizarov assigned elizarov and qwwdfsad and unassigned elizarov Feb 23, 2019
qwwdfsad added a commit that referenced this issue Mar 6, 2019
@qwwdfsad
Replace UI with Dispatchers.Main in CoroutineScope documentation
d1a05f3 
Fixes #803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elizarov @qwwdfsad @LouisCAD