-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Play Services artifact Gradle Module Metadata doesn't advertise the sources jar's existence #4112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
This also appears to affect kotlinx-coroutines-guava as well, which doesn't indicate that a sources jar is available: Expand to view kotlinx-coroutines-guava GMM
{
"formatVersion": "1.1",
"component": {
"group": "org.jetbrains.kotlinx",
"module": "kotlinx-coroutines-guava",
"version": "1.8.0",
"attributes": {
"org.gradle.status": "release"
}
},
"createdBy": {
"gradle": {
"version": "8.5"
}
},
"variants": [
{
"name": "apiElements",
"attributes": {
"org.gradle.category": "library",
"org.gradle.dependency.bundling": "external",
"org.gradle.jvm.environment": "standard-jvm",
"org.gradle.jvm.version": 8,
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-api",
"org.jetbrains.kotlin.platform.type": "jvm"
},
"dependencies": [
/* truncated */
],
"files": [
{
"name": "kotlinx-coroutines-guava-1.8.0.jar",
"url": "kotlinx-coroutines-guava-1.8.0.jar",
"size": 20285,
"sha512": "387d72b5cebc7b821c13dc168ff84c952bb76c5ced7ffcce07e40ba62e35ee5460f77778d50280c02853d387e3edf900564feda5837a6c8a00d5135039fef9c0",
"sha256": "650b3681fef3c82b900367fa3e1d8645f41891b3abe00b27bc6dbdeb2c2fa22b",
"sha1": "6109cffec886d6e112e5e2cbd3e0ec29f0bf6fee",
"md5": "c1faac8d2ec0b507acbcfa22999a6efb"
}
]
},
{
"name": "runtimeElements",
"attributes": {
"org.gradle.category": "library",
"org.gradle.dependency.bundling": "external",
"org.gradle.jvm.environment": "standard-jvm",
"org.gradle.jvm.version": 8,
"org.gradle.libraryelements": "jar",
"org.gradle.usage": "java-runtime",
"org.jetbrains.kotlin.platform.type": "jvm"
},
"dependencies": [
/* truncated */
],
"files": [
{
"name": "kotlinx-coroutines-guava-1.8.0.jar",
"url": "kotlinx-coroutines-guava-1.8.0.jar",
"size": 20285,
"sha512": "387d72b5cebc7b821c13dc168ff84c952bb76c5ced7ffcce07e40ba62e35ee5460f77778d50280c02853d387e3edf900564feda5837a6c8a00d5135039fef9c0",
"sha256": "650b3681fef3c82b900367fa3e1d8645f41891b3abe00b27bc6dbdeb2c2fa22b",
"sha1": "6109cffec886d6e112e5e2cbd3e0ec29f0bf6fee",
"md5": "c1faac8d2ec0b507acbcfa22999a6efb"
}
]
}
]
} |
I'm having this problem with |
dkhalanskyjb
added a commit
that referenced
this issue
Mar 25, 2025
Original implementation: https://github.com/vanniktech/gradle-maven-publish-plugin/blob/f22bd35c84c3df28700db4ca3de11d5b78a29fde/plugin/src/main/kotlin/com/vanniktech/maven/publish/Platform.kt#L472 Thanks, @vanniktech! The issue with the replaced implementation is that it only packs the jar, without registering the publication variant. Checking the sources of `java { withSourcesJar() }`, we see the corresponding logic, but given that we can instead invoke it directly, no need to reimplement it. Fixes #4112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Currently, sources for the
kotlinx-coroutines-play-services
artifact aren't recognised, resulting in IntelliJ decompiling the Kotlin source-code when viewing the source of a method, for example theTask.await()
method.This appears to be because the Gradle Module Metadata file that's published onto Maven Central doesn't advertise to end consumers that a sources jar is available, so IntelliJ doesn't download one:
(from https://repo1.maven.org/maven2/org/jetbrains/kotlinx/kotlinx-coroutines-play-services/1.8.0/kotlinx-coroutines-play-services-1.8.0.module)
Expand to view GMM file for kotlinx-coroutines-play-services 1.8.0
This is compared to the other artifacts (such as
kotlinx-coroutines-core-jvm
), which does expose that a sources jar exists:Expand to view GMM file for kotlinx-coroutines-core-jvm 1.8.0
Provide a Reproducer
(
gradle/libs.versions.toml
)Task.await()
await()
methodThe text was updated successfully, but these errors were encountered: