Skip to content

kotlin should be defined as a peer dependency to kotlinx-coroutines-core #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ansman opened this issue Apr 19, 2018 · 2 comments
Closed

kotlin should be defined as a peer dependency to kotlinx-coroutines-core #339

ansman opened this issue Apr 19, 2018 · 2 comments

Comments

@ansman
Copy link
Contributor

ansman commented Apr 19, 2018

Currently kotlin is defined as a regular dependency which means that it's not using the same runtime as your app module and things like instanceof might not work as expected.
@ansman ansman mentioned this issue May 1, 2018
Closed
ansman added a commit to ansman/kotlinx.coroutines that referenced this issue May 1, 2018
@ansman
Change kotlin to be a peer dependency
6378486 
This fixed Kotlin#339 and Kotlin#340
@ansman ansman mentioned this issue May 1, 2018
Closed
elizarov pushed a commit that referenced this issue May 14, 2018
@ansman @elizarov
Change kotlin to be a peer dependency
f2640d0 
Fixes #339
Fixes #340
@LouisCAD
Copy link
Contributor

LouisCAD commented Jun 5, 2018

Does this issue only strike in KotlinJS?

@ansman
Copy link
Contributor Author

ansman commented Jun 5, 2018 •
edited
Loading

Yes, on Java and native there can only be a single version any library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change kotlin to be a peer dependency ansman/kotlinx.coroutines
2 participants
@ansman @LouisCAD